Cloner "clone" topic checks are completely ignored.

Created by: DarkDibblez

Description of issue

The cloner console will run pod.growclone(C) regardless of any checks it does beforehand.

Difference between expected and actual behavior

Expected: Cloner console realizes it can't clone this person due to whatever reason (not enough biomass, clone pod already occupied, etc) and shows a descriptive error message indicating the issue(s).

Actual: Cloner console tries to fire the cloning code regardless, and only if THAT fails it shows a generic error message that explains nothing.

Steps to reproduce

n/a

Specific information for locating

code\modules\medical\computer\cloning.dm lines 327-367.

The cloner console does a bunch of checks before calling the pod.growclone function and it looks like it's supposed to break on these issues. It completely ignores the result of the checks and calls growclone anyway, which in turn overwrites the temp var that held the original error code.

This originally caused the doubleclone issue (#12327 (closed) & #8336 (closed)) because neither the console nor the cloner checked if something was already inside.

Length of time in which bug has been known to occur

Since forever, I would assume.

Server revision

current

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of not being yelled at by every contributor.

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this