Skip to content

Chemistry Sanity Redux

Rob Nelson requested to merge pull/6806/Chem-Hotfix-V2 into Bleeding-Edge

Created by: dylanstrategie

I'm aware that it can't be previewed, but I can't do any better since I have to modify the entire file to implement this and Chemistry-Reagents.dm is sorta huge

  • All helper procs now handle sanity checks (holder, istype, etc). This massively reduces the amount of redundant checks for individual reagents, and limits shitcode
  • Mob related procs now expect to be passed a mob/living, and will return if they don't
  • Turf related procs now expect to be passed a turf/simulated, and will return if they don't
  • All reagents should now call for parent. Fixes #6294 (closed)
  • Removed all self.remove_reagent from reagent code (instead changed to custom_metabolism). Only exception is Discount's Dan Sauce
  • All reaction_turf procs that create cleanables (with the notable exception of blood) will now return if there already is a cleanable of the same type on the turf
  • Moved reagent Destroy() back to the top of the file, instead of having it stuck right above vinegar
  • A lethal amount of formatting

All balance changes were held off for a potential follow-up PR. This PR is meant to clean up Chemistry-Reagents.dm to make it less of an ungodly pain in the ass to work with and overhaul further (notably in the scope of a future, potential chemistry rework)

Smaller scope version of #6302 and more atomic

Merge request reports