Skip to content

Refactors stripcode, the oldest, crappiest, and most bizarre code I have ever seen

Rob Nelson requested to merge pull/10490/nevertipastripper into Bleeding-Edge

Created by: 9600bauds

And does a lot of housekeeping around inventorycode to make it less of a pain in the ass to eventually refactor. I swear this shit was worse than lifecode.

Changelog

Trying to put an item in the wrong slot via the stripping menu now gives an explicit error message, so as to not waste your time. Buffed the Pickpocket's Gloves: Their effects now apply to all storage slots, not just ID and pockets. Fixed items in your pocket slots not applying their on_found() effects (e.g. mousetraps) when stripped individually, only when your jumpsuit was stripped. Fixed items in your pocket slots not applying their on_stripped() effects (e.g. SPS) when your jumpsuit was stripped, only individually. You can now toggle someone's suit sensors via the stripping menu, without having to remove their jumpsuit. There is now one unified option to toggle other people's internals via the stripping menu, which is available even if they have a tank in their pockets or hands. Simplified the way toggling internals chooses a tank: It will now simply look in your suit storage, then back, then belt, then pockets, then hands. It will also only take internals from a jetpack as last option. Removes the ability to perform CPR on alien larvas. Sorry guys. Accidentally fixed bug where you could spam CPR and do CPR multiple times at the same time in the same mob. Sorry guys.

To do

  • The changelog
  • See if there's a way to make the inventory screen not reopen itself when refreshing if it was closed
  • Test this shit
  • Fix monkey HUD not updating when equipping to slot
  • Let you know if internals are on or off before setting them via stripping menu
  • Fix reversestripping borg modules and cantdrop items
  • Find the issues that this closes

Resolves #8222 (closed), Fixes #7760 (closed), Resolves #9969 (closed)

  • Remove src.

To test

  • Test stripping out of every slot imaginable
  • Test stripping out of every slot imaginable, with monkeys
  • Test stripping out of every slot imaginable, including naughty href stuff
  • Test stripping into every slot imaginable
  • Test stripping into every slot imaginable, with monkeys
  • Test stripping into every slot imaginable, including naughty href stuff
  • DNA Injector: With monkeys, test logging with block and general injectors to see if it picks up monkeying
  • Cuffs: As borg, test logging, test resisting out of
  • Cuffs: Test breaking with hulk and freedom implant
  • Syndicuffs, test if they play nice when detonating and when explodified etc
  • Reverse stripping borg modules, including emag modules
  • Stripping undroppable items, including reverse stripping
  • Reverse stripping 2handed items in improper circumstances, also stripping offhand items
  • Internals, internals logging
  • Setting suit sensors
  • Canister logging
  • Pocket on_found and stripped behavior, when dropped via uniform stripping and when stripped directly
  • Test Diona and other monkey child's UI, stripping for shit they can't wear
  • Test naughty href stuff
  • CPR

Concerning comments I found while working on this PR

atom_2016-06-03_19-57-20 atom_2016-06-03_20-23-40 atom_2016-06-03_20-24-46 atom_2016-06-05_16-27-39 atom_2016-06-05_16-47-17 atom_2016-06-05_18-52-05 atom_2016-06-05_21-45-50 atom_2016-06-06_01-39-38 new atom_2016-06-12_21-08-21

Merge request reports