Skip to content

Fixes #10904

Rob Nelson requested to merge pull/10912/branchnamemicecannotunbucklepeople into Bleeding-Edge

Created by: 9600bauds

Fixes #10904 (closed) Pull requests must be atomic. Change one set of related things at a time. Bundling sucks for everyone. This means, primarily, that you shouldn't fix bugs and add content in the same PR. When we mean 'bundling', we mean making one PR for multiple, unrelated changes.

Test your changes. PRs that do not compile will not be accepted. Testing your changes locally is incredibly important. If you break the serb we will be very upset with you.

Large changes require discussion. If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014. Map and sprite changes require pictures of before and after. MAINTAINERS ARE NOT IMMUNE TO THIS. GET YOUR ASS IN IRC.

Merging your own PRs is considered bad practice, as it generally means you bypass peer review, which is a core part of how we develop.

It is also suggested that you hop into irc.rizon.net #vgstation to discuss your changes, or if you need help.

Merge request reports