Skip to content

Ports TG's instrument system and guitar

Rob Nelson requested to merge pull/11204/InstrumentPort into Bleeding-Edge

Created by: JustSumBody

Continuing where Unid left off in #5442 To be honest he had most of the leg work done already, all that was really left was cleaning up the sound files and changing the violin/piano pathing in virtually every place it came up. So we're moving to a new system that is flat based: rather than having duplicate sound files such as F#/Gb we just have the Gb file and the proc will send F# to Gb because music theory. It also eliminates reduntant files such as E# and directs them to Fn because why would you ever write an E# you animal. Couldn't find the inhand sprite for the guitar from his original PR though, searching for icons is hard. I'll look a bit harder/bug someone else to make one if I can't find it. Also of note: The guitar is limited in range. While the other instruments have a full range spanning nine octaves, the guitar is limited from the 3rd octave to the 6th or something like that I'm not that good at music. If you try to play something too high or low it just doesn't play. "Tested" moderately Sprite: image

FOUND THE IN HANDS: image image It's hard to get good ingame screens of the different views because of that whole layering thing, but you should get the idea edit: Oh there it is, my /tg/ branch was outdated so I didn't see the guitar now with video https://www.youtube.com/watch?v=HAWBF-G4CJM

Merge request reports