Skip to content

WIP: Fishing

Rob Nelson requested to merge pull/11929/fishing into Bleeding-Edge

Created by: BarneyGumball

VIDEO: https://my.mixtape.moe/wfbkgn.webm

This PR adds fishing rods and shit to use it with. Please critique and tell me how I need to rewrite everything.

New features include:

  1. Fishing Rods
    • Can be baited with different types of predefined bait
    • Different types rods can potentially take different kinds of bait and fish different kinds of items
  2. Bait
    • Can potentially use any type of obj/item as a bait type
    • Has a list of items that can be caught, along with setting probability of catching each item
  3. Fish
    • Adds fish as a food type. Several types available, but they all produce the same fillet for the time being.
    • Can be filleted using kitchen knives
    • Can contain pretty much anything (will be spawned when the fish gets filleted)
    • Carp meat has been converted to a type of fish fillet (functionally exactly the same)
  4. Bluespace Pond
    • No access to real water on the station, so this new piece of machinery is an expandable "pond-in-a-box". Using a multitool on the box unpacks it (like the AME) and using a wrench on it packs it back up
    • This and deep water, are currently the only atoms that can be fished
    • density = 1 because people can't walk on water. Should be fine seeing as you can repack ponds into boxes
  5. Recipes
    • All carp recipes except cubancarp and carp sliders have received a normal fish counterpart
    • New sushi recipe using actual fish
    • Clownfish fillets can be cooked into a new recipe "clownfish and crayons". When eaten, it gives the clumsy disability
  6. New supply pack
    • Contains everything needed to go fishing with (bluespace pond containers, fishing rods, bag of bait, food bag to put fish in)
  7. New clownfish mob
    • Thanks to the sweet sprites by @Blithering we have a new carp subtype that can be caught by using a clown mask as bait. They can't spawn children, but are friendly to pheromones.

What's left?

  • add type of fish I forgot before making this PR

SPRITES DONE. Thanks to @Blithering for the help.

  • NEEDED SPRITES
    • fishing rod
    • bait
    • normal fish
    • clownfish
    • bluespace pond (need multiple for connecting pieces together)
    • clownfish fillet
    • clownfish and crayons dish
  • NOT NEEDED, BUT WOULD PROBABLY BE GOOD SPRITES
    • new fish fillet sprite (either for carp fillets or normal fillets)
    • new sushi sprite (to distinguish from the eggplant sushi)
    • new sprites for the normal fish food (could also make new ones for the carp based food, and make the current carp sprites the normal sprites)
      • fish and chips
      • fish fingers
      • sashimi

Merge request reports