Skip to content

Code cleanup of virus2, removed effectholder and split it up between effect and disease

Rob Nelson requested to merge pull/13030/feature/remove_effect_holder into Bleeding-Edge

Created by: despotate

  • This does NOT fix any bugs
  • This does NOT add any gameplay features
  • This DOES make it significantly easier and simpler to add effects, fix virus2 bugs, and change disease behaviour which I plan on doing when this PR is merged.
  • This DOES add very helpful (not dylan-style """helpful""") comments to effect to help people create new symptoms
  • This DOES fuck with some public interfaces in disease and change some comments there
  • This DOES change some virus logs
  • This DOES touch a few non-virus2 files that used virus2

These tests were done in-game on my version of the server. They all replicated old behavior:

  • Examining virus dish
  • Growing a virus dish in incubator
  • Minor mutating a virus dish in incubator
  • Major mutating a virus dish in incubator
  • Directly calling major mutate on a virus dish
  • Copying a virus dish in incubator by pressing it to blood, then mutating the incubator dish, with the blood virus staying unchanged
  • Analyzing a virus
  • Analyzing a mutated virus
  • Analyzing a spliced virus (which it does instantly, but this is a bug that's existed before and has not been touched in this iteration of the code)
  • Splicing an effect out of a virus
  • Burning an effect to disk
  • Splicing an effect into a virus
  • Injecting a virus into oneself
  • Tested spinning the fuck out of control
  • Tested really low chance effects almost never triggering
  • Tested getting critted in five seconds when deciding to chance the percentage chance of shutdown syndrome activating from 1 to 100
  • Tested tajaran transformation from virus while in crit
  • No runtimes

What WASN'T tested:

  • The vampire code
  • The human say code

Merge request reports