Skip to content

wherein I attempt to fix Goofball's shit as much as humanly possible, but alas, I am only a human after all

Rob Nelson requested to merge pull/4155/goofballshit into Bleeding-Edge

Created by: 9600bauds

FIXED:

  • " cake" and other naming issues (#4189 (closed)) (yes it does fix #4189 (closed)) (fixes #4189 (closed))
  • Nearly every customizable single food item having 0 ingredients when created
  • Your initial ingredient being lost to the void
  • Everything was giving bright-colored empty shells of a custom food item
  • What the fuck?
  • Candy machine was literally duplicating the item's name
  • Sandwiches having waffle hats when having their picture taken. I tried to not fix it but accidentally fixed it at some point and couldn't break it again without breaking everything so rip waffle hats
  • Fixed (harmless?) runtime when adding deep-fried sandwiches to sandwiches. This stuff is just magical
  • delcious
  • Hamburger buns not being set to stackIngredients or addTop, having an icon_state, having an actual icon for the bottom bun, being craftable, working at all, just, hamburger buns in general.
  • Dough not being craftable due to using /food/snacks/flour rather than /food/drinks/flour.
  • You can now use a bread slice on an open-end sandwich to actually give it a top.
  • Still-made drinks are now properly glass-bottled.
  • Still-made drinks now actually inherit chemicals from the thing they're made from.
  • Removed goof
  • "fullycustom" plate dish not having the "fullyCustom" variable, literally only used for itself (c'mon now)
  • Even after adding the variable it still wasn't working
  • Added a helper proc to count the empty lines on the bottom of an icon, used for the "fullycustom" plate dish so the dish doesn't fucking phase through the plate.
  • Fixed removing ingredients mid-cooking being extremely buggy since the cooking process had just one big long sleep() with no sort of sanitychecking before or after.
  • Fixed being able to pick up the ingredient from the grill, which would then continue grilling in your hand.
  • Fixed the lack of any sanitychecking whatsoever when inputting an ingredient in a cooking machine, which allowed you to somehow jam it into multiple machines at once and then fucking breaking everything when any of those cooking results were eaten god DAMN
  • For whatever god-forsaken and unexplainable reason, soup was coded to allow glass shards as an initial ingredient, but since glass shards are not food it obviously broke everything, what the fuck
  • Renaming drinks didn't check for distance or whether the user was even alive, letting you rename the bottle even after dead by just leaving the window open.
  • I'mma grown up boy now ma I fix muh confrict
  • Rewrote the way food is updated so that the overlays are only drawn once, should make sandwiches less of a resource hog

OTHER:

  • Increased the maximum name length possible when renaming food with a pen, to better match the name length you can reach by quintuplestacking a sandwich or similar.
  • Nerfed the free nutriment you get from making custom food from 8 to 3 because honestly it was a bit ridiculous and doesn't actually cost any ingredients, thus letting you make nutriment out of nothing.
  • Rather than having every slice of a sandwich randomly bobble when new stuff was added to it, the X position of each slice depends on where you click when you add it.
  • Renamed "a hot mess" to "something yummy", I'm not yet sure why I did this
  • Changed cooking times to be more consistent, everything now takes around 15 seconds to cook, grill and deepfryer take around 20.

NOT FIXED:

  • Hamburger buns look like a nutsack.
  • The recipe for making dough is absolute ass (smack an egg with a container that has flour in it). In the future, we could make it so that all items that use small amounts of flour (donuts, spaghetti, hamburgerbuns etc) all require you to make dough, then you use your rolling pin on the dough and get a popup to choose what you want to make from it.
  • Cereal boxes' foodstuff overlay slightly breaks when used to make the "x on a plate" item, or if you re-cereal the cereal using #3399 (closed). This is due to limitations of getFlatIcon().
  • #4160 (closed)
  • I've heard reports of the Configure Food debug verb not working on the live serb, but I can't reproduce this myself

TODO MAYBE SOME OTHER TIME:

  • Maybe make it so that adding new ingredients to a non-stackable fooditem blends the colors of both ingredients together rather than replacing the previous color. I don't know, I've had enough of this for a while.
  • Still drinks look pretty tacky with just a solid color fill. They oughta be made to have transparency.
  • goal for the future: make custom cakes sliceable.

REMINDER:

  • To make sandwiches, use any ingredient on a slice of bread. Use a second slice of bread on the resulting open sandwich to add the top.
  • To make hamburger buns, slap an egg with a container that has flour in it to make dough. Then, put the dough in the microwave. I know, it's shit. Then, you can add stuff to the buns as if it were a sandwich.
  • To make pan pizzas, make dough and use the rolling pin on it. Then add stuff to the raw pizza base because cooking dough is for hippies.
  • You can also place your masterpiece on top of a plate to give it better presentation.

Merge request reports