Skip to content

Mostly fix cameras viewed from consoles

Created by: Exxion

X-ray cameras now work when viewed through consoles. (Fixes #4592 (closed).) This does not fix view_range doing nothing to cameras viewed through the console.

The DNM is because there is one very persistent and somewhat significant bug that I have tried and failed for a few hours to resolve. So I gave up and would like to ask for help with that.

Basically, exiting the console by using either cancel command in the selection window often leaves you with x-ray vision for a fraction of a second after your eye moves back to your mob. Exiting the console by using the cancel camera view verb works perfectly, though. Also, switching between cameras works fine. The problem occurs only when exiting the console by either clicking the cancel button or selecting the cancel option. It may or may not also occur if you leave the console by walking away from it; I forgot to test that.

I tried a number of fixes for that and all were exactly equally ineffective, so none are still included. Before you suggest it, calling handle_regular_hud_updates() does not work, even if it is called between unset_machine() and reset_view(null). I have no idea why.

Should be fine to merge once that is fixed, though. I hate the way this fix works, but I can't figure out a better one that would not require rewriting a good chunk of camera code.

Merge request reports