Skip to content

Bottles now use dynamic reagent filling sprites, tweaks to reagent container sprites

Rob Nelson requested to merge pull/5043/Chemistry into Bleeding-Edge

Created by: dylanstrategie

Progress in our code !

  • Fix #3881 (closed) for real this time. Lids and beaker sprites were all over the place (normal beakers, bottles and vials were offset one on the left, bluespace beakers were centered but offset two up, etc). Now all sprites expect for noreact are centered horizontally and synced vertically

Now onto the main change :

  • Bottles now use dynamic reagent fillings. For those who don't know what those are, when you fill a beaker with acid it very clearly shows the volume and the acid's color (orange). Bottles didn't have this, until now
  • Due to the way this works, a standard bottle sprite has replaced the dozens of snowflake bottles with pretty pre-filled sprites. The standard bottle sprite uses the same colors as the beaker
  • Bottles now fill dynamically every five units. Rounding used is +/- 2.5 % per step rounded up
  • Now, you will be able to tell immediately which bottle contains plasma, which one contains acid and which one contains your precious chloral
  • All pre-spawned bottles now use the base sprite. The reagent contents are still fairly obvious (especially for odd ones like ammonia). The custom sprites are still in the code but now no longer used (theorically)
  • Standardized procs from beaker to make sure sprite updates correctly

In-game example :

scrnshot1

Only current problem is that the Chemmaster had to be jury-rigged to not let the user use custom sprites, which are now outdated and most likely completely deprecated due to reagent fillings. Thus there is a "broken image" link replacing what used to be the bottle sprite selector. All code related to bottle sprite picking was commented for the time being

Merge request reports