Skip to content

Reverts DAL.

Rob Nelson requested to merge pull/5428/FULL-OF-SHIT into Bleeding-Edge

Created by: PJB3005

I did some profiles.

DAL is MORE THAN TWICE as expensive as baylights.

Relevant profiles here (Both were power cycling the entire station 5 times.):

I do not believe that the following should be taken as proof that baylights is worse, as this SHOULD be handled by scheck(); either scheck() is broken OR baylights just got caught in the crossfire of the fucking moronic panic writer.

EDIT: Here's what's causing the source of the spam of calls during "a bout of lag" in the following image.

update_lumcount(), the proc you see a LOT in the above image, is NOT expensive, it is some basic mathematical operations to check if lighting overlays actually get a visual change.

It gets called so much because it is the proc used to add or remove lumens to or from a lighting overlay, if an apply_lum() or remove_lum() call happens during "a bout of lag", this is bound to happen, as these are the procs that update the effect of light sources.

However after these procs are done, scheck() will kick in and pause the lighting controller.

TL;DR baylights was in the wrong place at the wrong time.

Also see my comments down below.

Merge request reports