Skip to content

Shuttle overhaul: this time with no areas

Rob Nelson requested to merge pull/5464/shuttles_2 into Bleeding-Edge

Created by: unid15

This is a rework of #5202 which broke the game and had to be put down Adresses #4998 (closed) https://github.com/Unfit/vgstation13/wiki/Guide-to-working-with-the-new-shuttle-system

This PR will make all shuttles use datums and docking ports instead of hardcode and areas. Yes, this means that there won't be any areas cluttering the map anymore and it'll be possible to build out of the escape airlock (but the emergency shuttle will still destroy everything) It will also give admins a lot of commands to play with the new shuttle system, including creating custom shuttles

http://puu.sh/jb3Xv/5f21d2b97d.webm

Note that the shuttle itself is still considered an area, however the locations it can travel to aren't. Shuttle rotation not supported yet

Changelog

  • The following shuttles are now port based: MINING, RESEARCH, SYNDICATE, VOX SKIPJACK, EMERGENCY, TAXIS, CENTCOM FERRY, ARRIVALS SHUTTLE (can't be moved without adminbus)
  • Shuttles now move some landmarks (latejoin, most importantly - so that the arrivals shuttle can be properly moved)
  • Shuttles have dynamic lighting
  • Added new shuttle control computers which can be linked to any shuttle
  • Added admin commands that abuse the new shuttle system very hard
  • New procs: shuttle_act(datum/shuttle/S) (for collision), can_shuttle_move(datum/shuttle/S) (for moving)

Map changes:

  • Most of the areas belonging to changed shuttles have been removed and replaced with docking ports instead; the docking ports are invisible and don't affect gameplay at all
  • Shuttles have been updated to include lights

Other info:

  • There are two types of docking ports - shuttle and destination. Shuttle ports are installed on shuttles and connect to destination ports. Destination ports CAN be installed on shuttles, and, when moved by a shuttle they move the connected shuttle as well

Milestones: 22/07:

  • Shuttles move properly

23/07:

  • Ported most of the common shuttles (vox, syndicate, salvage, escape, mining, research)
  • Updated boxstation
  • Docking between shuttles
  • Some adminbus commands

24/07:

  • Finished all adminbus commands
  • Made everything work properly
  • Dynamic lighting
  • Updated all maps

27/07:

  • Removed oldcode

31/07:

  • Pretty much ready for public testing

Merge request reports