Try #4 by me to fix preferences
Created by: Intigracy
Loops loading save until you load if you first successfully load preferences. Moves the while(!speciesinit) to before your save loading/random character generating, since loading preferences doesn't need it and is being delayed for no reason.
Justification:
WARNING: 231: datum/preferences/load_save_sqlite has returned in code/modules/client/preferences_savefile.dm at line 231 src: /datum/preferences usr: [whocaresabouttheckey]
This check implies they are failing to load a save because they don't have a save to load, but that's obviously false.
This happens in the runtimes since the WARNING message was added in my PR earlier today. The failure doesn't happen for the same people every round, which leads me to once again assume it's bottlenecking. If it is, this PR will definitively fix the issue.
TL;DR BOTTLENECKING